ARMmbed / ARMmbed/DAPLink

Invalid binary -> FAIL.txt "The transfer timed out."

Open
#667 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
2.8k
Forks
1.1k
Avg merge
3d 12h
Merged PRs (30d)
1

Description

When drag and dropping a nRF52 binary the first bytes are validated in to be valid.
https://github.com/ARMmbed/DAPLink/blob/master/source/daplink/validation.c#L55

The problem is if they are not valid, the FAIL.txt will contain
"The transfer timed out."
There seems to be an
else if( NNN){}
missing here
https://github.com/ARMmbed/DAPLink/blob/master/source/daplink/drag-n-drop/vfs_manager.c#L798

Contributor guide

Open the contributing guide

Research direction

Read source/daplink/validation.c around line 55 and source/daplink/drag-n-drop/vfs_manager.c around line 798, then trace how invalid nRF52 binary bytes reach the transfer result. Confirm the failure path reports an invalid binary in FAIL.txt rather than "The transfer timed out.".

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.