ARMmbed / ARMmbed/DAPLink

uart.c constant comparison issues

Open
#1,039 0 comments 0 reactions 1 assignee Claimed by @flit View on GitHub
Dominant language
C
Stars
2.8k
Forks
1.1k
Avg merge
3d 12h
Merged PRs (30d)
1

Description

In multiple uart.c files:

line 164 in `source/hic_hal/freescale/kl27z/uart.c`:
line 149 in `source/hic_hal/freescale/kl26z/uart.c`:
line 140 in `source/hic_hal/freescale/kl26z/uart.c`:
line 134 in `source/hic_hal/freescale/k20dx/uart.c`:

The comparison ```if (data_bits == 2) {``` is made, but `data_bits` is always <= 1; the comparison will always resolve to false.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.