ARK-Builders / ARK-Builders/ark-android

Move RootPickerDialog and prohibit adding a new root if there is already a root inside

Open
#68 1 comment 1 reaction 1 assignee Claimed by @tuancoltech View on GitHub
Dominant language
Kotlin
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Move [RootPickerDialogFragment](https://github.com/ARK-Builders/ARK-Navigator/blob/main/app/src/main/java/dev/arkbuilders/navigator/presentation/dialog/RootPickerDialogFragment.kt) here from Navigator
The functionality of the [RootPickerDialogFragment](https://github.com/ARK-Builders/ARK-Navigator/blob/main/app/src/main/java/dev/arkbuilders/navigator/presentation/dialog/RootPickerDialogFragment.kt) and the [ArkFilePickerViewModel.pinFile()](https://github.com/ARK-Builders/ark-android/blob/aa70a3ee2733cbd026b43939b558fbe4cc46e116/components/src/main/java/dev/arkbuilders/components/filepicker/ArkFilePickerViewModel.kt#L182) are the same. In fact, we can add root/favorite from two different places. We need to reuse the general logic and prohibit adding root if there is already a root inside.
We also need to prohibit adding device root as ARK root.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.