APS-4ID-POLAR / APS-4ID-POLAR/ipython-polar
What should we do when we stop a PVPositioner?
- Dominant language
- Python
- Stars
- 1
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
For example, if we move the temperature to 300K from 10K, and we decide to abort/pause in the middle. Should we make `pause` and/or `stop` update the setpoint?
This is what is currently done:
https://github.com/APS-4ID-POLAR/ipython-polar/blob/a22606fbf39bb71b375b41da94ebbec6507eb12c/profile_bluesky/startup/instrument/devices/lakeshore336.py#L122
https://github.com/APS-4ID-POLAR/ipython-polar/blob/a22606fbf39bb71b375b41da94ebbec6507eb12c/profile_bluesky/startup/instrument/devices/lakeshore336.py#L127
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reviewing the linked lakeshore336.py references, especially lines 122 and 127, to understand the current pause and stop behavior. Then examine the PVPositioner semantics and decide whether either action should update the setpoint; done means the expected behavior is agreed and documented with corresponding coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100