APS-4ID-POLAR / APS-4ID-POLAR/ipython-polar

Convert `mag6t.ramp_button` and `.switch_heater` to `PVPositioner`

Open
#100 1 comment 0 reactions 1 assignee Claimed by @gfabbris View on GitHub
enhancement
Dominant language
Python
Stars
1
Forks
3
PR merge metrics
No merged PRs in 30d

Description

One difficulty in this problem is that in each step we want to wait for certain conditions. For example, in the staging process, we first click on the ramp button, then wait for the supply current to match the magnet current, then turn on the switch heater, then wait for the magnet status to change. Currently this is done in a workaround, using the `SetSignal` that simply returns a subscription status based on an input device and function (Codacy doesn't like `SetSignal`). Then using `abs_set` (with `wait=True`) we can make the `RunEngine` wait for each step to complete.

I suspect the "best" way to do this is by converting `.ramp_button` and `.switch_heater` into `PVPositioner`. I will try to do it later, for now we can just leave it as is.

_Originally posted by @gfabbris in https://github.com/APS-4ID-POLAR/ipython-polar/issues/99#issuecomment-805865176_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.