AOSSIE-Org / AOSSIE-Org/Resonate

Potential invalid userRating calculation when ratingCount is zero

Open
#780 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Dart
Stars
344
Forks
350
PR merge metrics
No merged PRs in 30d

Description

### 🐛 Describe the bug

## A clear and concise description of what the bug is.

In `explore_story_controller.dart`, the user rating is calculated as:

userData['ratingTotal'] / userData['ratingCount'];

If `ratingCount` is 0 or null, this results in `Infinity` or `NaN` instead of a valid rating value.

Although this does not throw an exception in Dart, it can lead to incorrect or invalid values being displayed in the UI.

---

## Sample code to reproduce the problem

Example:

```dart
final ratingTotal = 0;
final ratingCount = 0;

final result = ratingTotal / ratingCount;
print(result); // NaN

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.