AOSSIE-Org / AOSSIE-Org/Resonate-Website

Bug: GSAP timeline instances not cleaned up in useEffect memory leak in page.jsx

未關閉
#307 3 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
TypeScript
星號
43
分支
154
PR 合併指標
30 天內沒有已合併 PR

描述

### 🐛 Describe the bug

**Description:**
```
In `app/page.jsx`, four GSAP timelines are created inside `useEffect`
but never killed in the cleanup function:

- `heroTl` (line 45)
- `techStackTl` (line 109)
- `aboutTl` (line 142)
- `downloadTl` (line 181)

The current cleanup only calls:
- `lenis.destroy()`
- `ScrollTrigger.getAll().forEach(t => t.kill())`

GSAP timelines hold references to DOM elements and tween objects
independently of ScrollTrigger. Without calling `.kill()`, these
accumulate on every remount causing a memory leak.

## Steps to Reproduce
1. Open app/page.jsx
2. Check the useEffect cleanup block (line 213)
3. Notice heroTl, techStackTl, aboutTl, downloadTl are never killed

## Proposed Fix
Add to the cleanup return block:
heroTl.kill();
techStackTl.kill();
aboutTl.kill();
downloadTl.kill();

Image

Image

## References
Related to #292 (Animation Lifecycle & Memory Safety Audit)

I'd like to work on this issue.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。