AOSSIE-Org / AOSSIE-Org/PictoPy

BUG:Images skipped silently when thumbnail generation fails

Open
#843 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
283
Forks
679
Avg merge
7d 2h
Merged PRs (30d)
3

Description

### Is there an existing issue for this?

- [x] I have searched the existing issues

### What happened?

Description
When thumbnail generation fails during image processing, images are silently skipped without any user notification. This leads to images missing from the database without the user knowing why

Problem
In the image_util_prepare_image_records function, when image_util_generate_thumbnail() returns False (indicating thumbnail generation failure), the code simply skips adding the image to image_records without logging any warning or error message. The user has no visibility into which images were skipped or why.

Solution
Added explicit warning logging when thumbnail generation fails, so users are informed about skipped images.
### Record

- [x] I agree to follow this project's Code of Conduct

### Checklist before Submitting

- [ ] Have you updated docs for it?
- [ ] Have you added unit tests?
- [ ] Have you made sure unit tests pass?
- [x] Have you made sure code formatting is correct?
- [ ] Do Your changes passes all tests?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.