AOSSIE-Org / AOSSIE-Org/PictoPy

Logging: InterceptHandler preserves exc_info and stack_info (should be cleared before formatting)

Open
#708 0 comments 0 reactions 1 assignee Claimed by @VasuS609 View on GitHub
backend bug
Dominant language
Python
Stars
283
Forks
679
Avg merge
7d 2h
Merged PRs (30d)
3

Description

### Is there an existing issue for this?

- [x] I have searched the existing issues

### What happened?

The InterceptHandler in backend/app/logging/setup_logging.py calls
self.format(record) while record.exc_info and record.stack_info are still set.

Python’s Formatter.format() automatically appends traceback and stack output if
these fields are truthy.

This violates the project rule that exc_info and stack_info should not be
preserved when rerouting logs.

Fix proposal:
record.exc_info = None
record.stack_info = None
msg = self.format(record)

This should be applied around lines 238–252.

### Record

- [x] I agree to follow this project's Code of Conduct

### Checklist before Submitting

- [x] Have you updated docs for it?
- [ ] Have you added unit tests?
- [x] Have you made sure unit tests pass?
- [x] Have you made sure code formatting is correct?
- [x] Do Your changes passes all tests?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.