AOSSIE-Org / AOSSIE-Org/NeuroTrack

fix: Don't use BuildContext across async gaps (use_build_context_synchronously)

Open
#197 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Dart
Stars
29
Forks
50
PR merge metrics
No merged PRs in 30d

Description

## Summary

`flutter analyze` flags **4 locations** across both apps where a `BuildContext` is used after an `await` without a proper `mounted` guard. This can cause crashes if the widget is unmounted between the async call and the context usage.

## Affected Files

### patient app
| File | Line | Detail |
|------|------|--------|
| `lib/presentation/result/book_appointment.dart` | 55 | `use_build_context_synchronously` |
| `lib/provider/therapist_provider.dart` | 65, 69 | `use_build_context_synchronously` |

### therapist app
| File | Line | Detail |
|------|------|--------|
| `lib/presentation/auth/personal_details_screen.dart` | 115, 124 | `use_build_context_synchronously` — guarded by an **unrelated** `mounted` check |

## Steps to Reproduce

```
cd patient && flutter analyze
cd ../therapist && flutter analyze
```

## Expected Behavior

All context usages after `await` are guarded by `if (!mounted) return` or the context reference is captured before the async gap.

## Fix

- Add `if (!mounted) return;` immediately after each `await` before accessing `context`
- In `personal_details_screen.dart`: move the `mounted` check to guard the specific context access (not an unrelated branch)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.