AOSSIE-Org / AOSSIE-Org/EduAid

The backend Script.sh needs to be optimized

Open
#93 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
171
Forks
425
PR merge metrics
No merged PRs in 30d

Description

1. Readability
If you or someone else revisits the script after some time, it can take extra effort to understand its intent.
If the script fails at some point, without clear explanations, tracking down the issue becomes more challenging.
2. Error Handling
The script could silently fail without any indication of the problem, causing later stages to rely on incomplete or missing files.
This could cause failures in other parts of the project that depend on the setup being complete (e.g., the repository files or Sense2Vec models being unavailable).
3. Efficiency
Over time, adding unnecessary steps (like redundant mkdir) can make the script harder to maintain and increase execution time, especially if you have larger scripts or workflows.
4. Proper Deactivation of Virtual Environment
f the script fails to deactivate the virtual environment properly, you may end up in a situation where the virtual environment is still active, potentially causing conflicts with other processes or scripts.
Leaving the virtual environment active unintentionally can cause problems in subsequent operations (like if you run another script that expects the global Python environment)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.