AMReX-Astro / AMReX-Astro/Microphysics

make helm_table read work when we are in single precision

Open
#238 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

EOS
Dominant language
C++
Stars
43
Forks
46
Avg merge
2d 18h
Merged PRs (30d)
15

Description

When we run in single precision, we still need to read in the helm table, which is stored as double precision. So we need to have a temporary buffer that is double precision to read to, and then cast into single precision.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the helm_table read path and the single-precision configuration in the repository. Trace how the table is currently read and identify the relevant precision-dependent tests or execution path. Done means single-precision runs can read the double-precision helm table and use the converted values correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.