AMReX-Astro / AMReX-Astro/Microphysics
add state checks for SDC to Rosenbrock
Open
Nobody has claimed this yet.
integrator
- Dominant language
- C++
- Stars
- 43
- Forks
- 46
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 15
Description
The Rosenbrock functions valid_integtrator_state and species_change_valid are not implemented for SDC.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Rosenbrock implementation and compare the existing valid_integtrator_state and species_change_valid handling with the SDC path. Implement the missing SDC state checks, then verify that both functions behave correctly for SDC.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100