AMReX-Astro / AMReX-Astro/Microphysics
are we filling y_e in the burn_state that get's passed to the nets?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 43
- Forks
- 46
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 15
Description
If we are using tabular weak rates, then we need burn_state.y_e.
For the Strang code path, it looks like we are filling this in update_thermodynamics.
But what about the SDC code path? It is not clear where it is filled.
We should add an assert on it in the pynucastro nets just as a check.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace how burn_state.y_e is populated in update_thermodynamics for the Strang path, then follow the SDC path to identify whether it is populated before the nets run. Review the pynucastro nets entry points and add the requested assertion; done means the assertion checks y_e and both paths are verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, python
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100