AMReX-Astro / AMReX-Astro/Microphysics
consider simplifying the NSE table integration
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 43
- Forks
- 46
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 15
Description
In https://github.com/AMReX-Astro/Microphysics/pull/1812 the time-integration algorithm for self-consistent NSE is modified to compute the update to (rho e) using the instantaneous value computed from the network, instead of doing the finite-difference (in time) approach we use with <B/A> with the table.
We could make this same change with the table, if we store the enuc value directly in the table. This is something we should experiment with.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading PR 1812 and the existing self-consistent NSE table time-integration path. Identify where the table currently provides <B/A> and where the update to (rho e) is computed. Done means evaluating and documenting whether storing enuc directly in the table provides a sound replacement for the finite-difference approach.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100