AMReX-Astro / AMReX-Astro/Microphysics
Allow using BackwardEuler integrator instead of VODE
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 43
- Forks
- 46
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 15
Description
Currently VODE parameters are hard-coded in CMakeLists.txt:
set(VODEparamfile "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/integration/VODE/_parameters")
and I have to manually change it to
set(VODEparamfile "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/integration/BackwardEuler/_parameters")
in order to use BackwardEuler integrator. If I don't make this change and include integration/BackwardEuler in cmake, I get complain about max_iter not defined. It would be nice to be able to choose whatever integrator you like in your code and get the right paramfile.
Context: this is part of the effort to couple multi-group radiation hydrodynamics with thermochemistry in Quokka.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the VODEparamfile definition in CMakeLists.txt and compare integration/VODE/_parameters with integration/BackwardEuler/_parameters. Trace how the selected integrator is included in CMake and verify that choosing BackwardEuler resolves the max_iter error without manually editing the parameter-file path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100