AMReX-Astro / AMReX-Astro/Microphysics

Fix bug in primordial chemistry chemical heating

Open
#1,641 0 comments 0 reactions 1 assignee View on GitHub

@psharda is already working on this.

Since Aug 21, 2024.

bug
Dominant language
C++
Stars
43
Forks
46
Avg merge
2d 18h
Merged PRs (30d)
15

Description

This bug fix needs to be propagated across the primordial chemistry pipeline: https://github.com/psharda/GPUAstroChem/commit/ea95fb62d3b79fa18db5e5dc796c5974d8767bea

It does not matter for primordial chemistry, but creates a 10% error at low, non-zero metallicities. Just noting it down for now in case I forget to fix it later on.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.