AMReX-Astro / AMReX-Astro/Microphysics
what's the purpose of integrate_energy now?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 43
- Forks
- 46
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 15
Description
It is unclear what the purpose of setting integrator.integrate_energy = 0 is now. If we want to decouple the energy release from the temperature, e.g., to do a constant T burn, we do integrator.call_eos_in_rhs = 0. But we still want to include the energy equation in the integration, since that accumulates the energy release. If we turn off energy integration though, then the energy release from the burner will be 0, even if the composition changes. Is that something we want?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the integrator behavior around integrator.integrate_energy and integrator.call_eos_in_rhs, then compare how energy release is accumulated when composition changes. The issue does not mention specific files or tests; done would require a decided explanation of the intended behavior and corresponding documentation or code clarification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Documentation
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100