AMReX-Astro / AMReX-Astro/Microphysics
switch Strang integration to work with (rho X, rho e)
Open
Nobody has claimed this yet.
integrator
- Dominant language
- C++
- Stars
- 43
- Forks
- 46
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 15
Description
Right now Strang integrates (X, e) and SDC integrates (rho X, rho e). We should sync them.
algebraically, since rho is constant in Strang integration, this should not affect things much (except how atol is interpreted). But it will make code reuse between SDC and Strang much easier.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Strang and SDC integration implementations and compare how each represents (X, e) versus (rho X, rho e). Update the Strang path so both integrations use the same variables, then verify the resulting atol behavior and existing integration tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100