AMReX-Astro / AMReX-Astro/Castro
revisit ppm_temp_fix
@zingale is already working on this.
Since Feb 19, 2020.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
At it's peak, we had 3 options for including temperature in the reconstruction of interface states:
ppm_temp_fix = 1would reconstuct T and then use the EOS to get p, and the rest of the algorithm would proceed as normalppm_temp_fix = 2modifies the Riemann solver to enforce thermodynamic consistency on the interfaces by recomputing p via the EOSppm_temp_fix = 3used a tau, u, T eigensystem for the characteristic tracing. This was removed in #764
It turns out that ppm_temp_fix = 1 only works with ppm_predict_gammae = 1 due to an oversight. We have also not been using it. In PR #780 , we will remove the gammae reconstruction, since that has not been shown to help much.
We will also be temporarily removing ppm_temp_fix = 1 in that same PR. This removal means that there will be no more EOS calls in any of the reconstruction, so we can go ahead with the port to C++ (since not having the C++ EOS is the current blocker).
Once the C++ EOS PRs are merged, we should go back and explore these temperature fixes again, in a more controlled study, to understand where they might be beneficial.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.