AMReX-Astro / AMReX-Astro/Castro
better treatment for inflow BCs
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
For inflow BCs, we should adopt the strategy from Maestro and others where the ghost cell value represents the interface value, and not the cell-center. And then we should use modified stencils at the edge to ensure that we see the correct inflow state.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names inflow boundary conditions, ghost-cell interface values, and modified edge stencils, but it names no files, entry points, or tests. Start by locating the inflow-BC implementation and related stencil tests; done means the treatment matches the stated interface-value strategy and produces the correct inflow state at the edge.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100