AMReX-Astro / AMReX-Astro/Castro
add proper subsonic characteristic outflow boundaries
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
We should look into adding subsonic outflow boundaries. Maybe we can adapt the code from here:
https://ccse.lbl.gov/people/motheau/Manuscripts_website/2017_AIAA_CFD_Motheau.pdf
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no source files or tests. Start by reading the linked 2017 AIAA CFD paper and locating Castro's existing outflow-boundary implementation, then compare its behavior with the requested subsonic characteristic treatment. Done means the new boundary behavior is implemented and validated with suitable simulation or regression coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100