AMReX-Astro / AMReX-Astro/Castro
HLLC solver does not work with axisymmetric coords
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
The HLLC solver approximates the flux on the interfaces directly. For Cartesian coords, the pressure term is part of the momentum flux, so there is no issue.
For axisymmetric coords, this is not the case. The solution is to either include it in the flux and then have an explicit (non-conservative) geometric source term or ignore it in the flux. In either case, we still need a valid edge-centered, time-centered pressure.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the HLLC solver and the axisymmetric flux and geometric-source handling. Compare how Cartesian pressure fluxes are treated, then determine how to provide a valid edge-centered, time-centered pressure while consistently choosing the flux and source-term treatment. Done means the axisymmetric HLLC solver produces a valid pressure treatment without breaking the Cartesian case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100