AMReX-Astro / AMReX-Astro/Castro
Is FillPatch needed in diffusion?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
Currently in the construction of the diffusion term, we do a FillPatch on the full state. But for the predictor (with CTU) or with any MOL-based hydro, we come into the diffusion with Sborder, which already has filled ghost cells. So are we doing the FillPatch unnecessarily here?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the diffusion-term construction and the predictor paths mentioned in the issue, including CTU, MOL-based hydro, and Sborder. Determine whether the full-state FillPatch is redundant in each path and establish the expected behavior before proposing a change; no file or test is identified in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100