AMReX-Astro / AMReX-Astro/Castro
implement reference counting system for eos state
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
We should use a reference count-like system to keep track of the EOS state. Anytime an operation does something that we believe breaks thermodynamic consistency, we increment the counter. If the counter > 0, then we know not to trust the state, and instead need to call clean_state.
This will let us be more consistent with the EOS calls.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the existing EOS calls and the clean_state entry point to identify where thermodynamic consistency can be broken. Determine which operations must update the reference count and how state validity is checked. Done means the counter reliably triggers clean_state before untrusted EOS use, with coverage for the affected operations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100