AMReX-Astro / AMReX-Astro/Castro
slipwall and noslipwall are the same
Open
Nobody has claimed this yet.
bug :bug:
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
The implementation of the slipwall and noslipwall boundaries in Castro_setup.cpp appear to be identical. noslipwall should force the transverse velocity to 0.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the slipwall and noslipwall boundary implementations in Castro_setup.cpp and compare how they handle transverse velocity. The issue is done when noslipwall forces the transverse velocity to 0 while slipwall retains its distinct behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100