AMReX-Astro / AMReX-Astro/Castro
Unclear if hybrid momentum BCs are set correctly
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
In Castro_setup.cpp, for the hybrid momenta I used the scalar_bc for setting physical boundary conditions. But I think this may be incorrect. In particular, radial momentum and angular momentum are position dependent, so something like a piecewise constant extrapolation may not give a meaningful value.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading Castro_setup.cpp where scalar_bc is applied to the hybrid momenta. Investigate how radial and angular momentum depend on position and determine whether the current physical boundary treatment is meaningful. Done means the correct boundary-condition approach is established and its behavior is validated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100