AMReX-Astro / AMReX-Astro/Castro
Modifying the CFL for a custom diffusion term
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
Following this issue #3132, we would like to modify the CFL based of the diffusion coefficient computed in our custom thermal diffusion operator, since if we disable Castro thermal diffusion the limiting time step will be the hydrodynamic one. Is there any simple way to do this or should we modify Castro directly ?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading issue #3132 and the Castro thermal-diffusion and CFL handling referenced here. No files or tests are named, so first locate those entry points and determine whether a custom thermal diffusion coefficient can affect the timestep without changing Castro directly. Done would be a clearly supported approach or a documented decision about the required Castro modification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100