AMReX-Astro / AMReX-Astro/Castro
Not masking in the SCF diagnostic code
Open
Nobody has claimed this yet.
self-consistent field init
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
In #3278 we fixed some issues in the SCF diagnostics. But it seems like in that same place, when we are computing the total mass, we are accumulating over all levels, and not masking out grids that are covered by fine levels.
I think that we should be using a mask here.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the SCF diagnostic code changed in issue #3278, focusing on where total mass is accumulated across levels. Determine how masking is handled there; done means covered grids are excluded from the total-mass calculation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100