AMReX-Astro / AMReX-Astro/Castro
simplified-SDC w/o burning just needs a single iteration
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
For any zone that does not meet the conditions for burning (e.g., density / temperature thresholds), the second iteration of the simplified SDC is essentially a no-op, since the advective term should be the same as from the first iteration. Note: this assumes that we didn't burn in the previous zone either because of the lagged reactive source predictor.
We can detect this and just copy the advective term instead of reconstructing it in these cases. For problems that evolve a bit before we burn (like wdmerger) this could save some time.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the simplified SDC implementation and trace the second iteration for zones that do not meet the burning conditions. Compare the advective term across iterations, then use the wdmerger problem to verify that skipping reconstruction preserves results and improves runtime.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc, performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100