AMReX-Astro / AMReX-Astro/Castro

update yt frontend for exotically named nuclei

Open
#3,032 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
340
Forks
105
Avg merge
3d 8h
Merged PRs (30d)
8

Description

yt Pull #4908 changes the way that the names of nuclei are interpreted. Due to this, an error is raised for species data that is not of the designated naming format. For example, when trying to plot a Castro dataset with something such as X(P_nse), we get: ValueError: 'X(P_nse)' doesn't match expected regular expression. The root of the error stems from line 515 of yt/frontends/amrex/fields.py.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at line 515 of yt/frontends/amrex/fields.py and review yt Pull #4908, which changed nucleus-name interpretation. Reproduce the failure with a Castro dataset containing species data such as X(P_nse). Done means that this exotic name is accepted without the reported ValueError.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
hpc
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.