AMReX-Astro / AMReX-Astro/Castro
SDC/MOL doesn't work with multilevel
Open
Nobody has claimed this yet.
sdc
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
we need to come up with a scheme to do the ghost cell fill for the intermediate stages (which is not trivial with RK integration).
we also need to address the source refluxing in Castro.cpp (in particular, we should never call do_new_sources() with MOL.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Castro.cpp and trace the SDC/MOL multilevel integration path and do_new_sources(). Define the intermediate-stage ghost-cell-fill and source-refluxing requirements, then verify that multilevel SDC/MOL runs do not call do_new_sources() in MOL mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100