AMReX-Astro / AMReX-Astro/Castro

Prohibit burning in shock zones by default

Open
#2,984 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

reactions
Dominant language
C++
Stars
340
Forks
105
Avg merge
3d 8h
Merged PRs (30d)
8

Description

Prohibiting burning in the numerically broadened shock structure is a common prescription in stellar detonation simulations (some double detonation examples: Townsley 2016, Shen 2018, and Rivas 2022). This practice stems back to Fryxell 1989, with a robust analysis using a Type Ia domain in Papatheodore 2014. I have also probed this treatment in 1D using Castro's subch_planar problem setup and have attached an image of the results at t = 0.180s, where we can see that the flames converge with increasing resolution towards a prescription that prohibits burning in zones containing the shock front. The mechanism in which Castro uses to detect shocks can be seen in the Appendix of Zingale 2024. At the moment, Castro does not prohibit shock burning by default, which perhaps should be changed to ensure accurate nuclear modeling.

shock_probe_del50

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the attached 1D comparison with Castro's subch_planar problem setup and review the shock-detection mechanism described in the cited Zingale 2024 appendix. Determine how burning is currently handled in zones containing the shock front, then define validation around the expected convergent flame behavior and a default that prohibits shock burning.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.