AMReX-Astro / AMReX-Astro/Castro

Implement optimal subcycling

Open
#276 1 comment 0 reactions 1 assignee View on GitHub

@maximumcats is already working on this.

Since Dec 12, 2017.

driver enhancement
Dominant language
C++
Stars
340
Forks
105
Avg merge
3d 8h
Merged PRs (30d)
8

Description

Optimal subcycling is done in Nyx, and I want to implement this as an option in Castro. This involves two steps:

  1. during timestep estimation, call the Amr function which determines whether to subcycle the finer levels, and set the timestep appropriately

  2. during the advance, do the hydro advance / reflux and gravity solves on the current level and all finer levels which have ncycle == 1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.