AMReX-Astro / AMReX-Astro/Castro
template Riemann solvers on idir
Open
Nobody has claimed this yet.
good first issue
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
We have a lot of branching logic in the Riemann solvers that checks the direction, idir. These can easily be eliminated via templating.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Riemann solver implementations and the branching on idir described in the issue. Review how direction-specific behavior is currently selected, then confirm that templating removes the branching while preserving solver behavior in every direction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100