AMReX-Astro / AMReX-Astro/Castro
create an API for updating runtime parameters
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
For most runtime parameters, we read them at initialization and they never change. But we have a few cases where depending on the values of other parameters, we change some. This should be done explicitly through a setter function so we can catch changes when we transition to structs for the runtime parameters.
Here's a partial list of runtime parameters that we override:
do_reflux(inCastro.cpp,read_params())rot_axis(inCastro.cpp,read_params())sdc_iters(inCastro_advance_ctu.cpp)small_temp,small_dens,small_pres,small_ener(all inCastro_setup.cpp)rotational_period(inCastro_io.cpp,scf_relax.cpp)point_mass(inCastro_io.cpp,Castro_pointmass.cpp)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the runtime-parameter initialization and override paths in Castro.cpp/read_params(), Castro_advance_ctu.cpp, Castro_setup.cpp, Castro_io.cpp, scf_relax.cpp, and Castro_pointmass.cpp. Define the setter API around the listed parameters and update those override sites so changes are explicit and ready for the transition to structs; verify every listed parameter uses the API.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100