AMReX-Astro / AMReX-Astro/Castro

switch sum_utils to use AMReX volwgtsum

Open
#2,276 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
340
Forks
105
Avg merge
3d 8h
Merged PRs (30d)
8

Description

AMReX now has a volwgtsum function:
https://github.com/AMReX-Codes/amrex/pull/2961

we should be able to use this in place of the Castro version in sum_utils.cpp

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read sum_utils.cpp and the AMReX volwgtsum pull request linked in the issue to compare the existing Castro implementation with the available AMReX function. Replace the Castro version with volwgtsum, keeping the surrounding behavior unchanged; completion means sum_utils.cpp uses the AMReX implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.