AMReX-Astro / AMReX-Astro/Castro

add capability to use James solver for gravity BCs

Open
#2,271 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
340
Forks
105
Avg merge
3d 8h
Merged PRs (30d)
8

Description

AMReX now has a James BC solver:

https://github.com/AMReX-Codes/amrex/pull/2912

we should add the ability to use this instead of the multipole solver for BCs.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the referenced AMReX James BC solver pull request and locating Castro's existing multipole solver path for boundary conditions. Determine how the James solver should be selected and verify that boundary conditions can use it in place of the multipole solver; the issue provides no file or test names.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.