AMReX-Astro / AMReX-Astro/Castro
Recommend a new default value of gravity.abs_tol
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
The Poisson solve absolute tolerance sets the accuracy of the Poisson solve. Given the value of abs_tol, the error level targeted in the Poisson solve is abs_tol * 4 * pi * G * rho_max, where rho_max is the maximum density on the domain. For Cartesian simulations the default value is 1.e-11, and for non-Cartesian the default value is 1.e-10.
At high resolution, and/or for complicated mass distributions, this tolerance can be too tight, and the multigrid solve fails. We should study the effect of the gravity tolerance and possibly recommend a new tolerance. If it is justified, the new tolerance should be looser so that the default value fails in fewer cases. However, we should not make it so loose that the effect noticeably deteriorates the accuracy of our simulations.
Issues to study:
(1) Differences between Cartesian and cylindrical/spherical problems
(2) Performance, both for a single processor and for multiple processors
(3) Accuracy -- for a given lower tolerance, how much does the answer change?
These should be studied with a well-used problem like DustCollapse, and also one or two more complicated problems like the Evrard collapse and wdmerger.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the gravity.abs_tol setting and the DustCollapse, Evrard collapse, and wdmerger problem setups. Compare Cartesian with cylindrical or spherical cases, single- and multi-processor performance, and solution accuracy across looser tolerances. Done means identifying whether a new default is justified and documenting the recommended value and its effects.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc, performance
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100