AMReX-Astro / AMReX-Astro/Castro
reimplement stellar boundary conditions
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
Sometimes we only model a portion of a star, with the surface outside of the computational domain. We used to have the ability to spherically average the star on the grid and use this profile to initialize the ghost cells. This was removed in 5e8a228fc4e3b05fec53acca2d2a7dd2de0ab290
We should add this back in. Perhaps extending the model via HSE to get the corners of the domain correct too.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing commit 5e8a228fc4e3b05fec53acca2d2a7dd2de0ab290, which removed the prior spherical-averaging behavior. Restore the ability to use a spherically averaged stellar profile to initialize ghost cells when the surface lies outside the computational domain; the optional HSE extension for domain corners needs its expected behavior defined.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100