AMReX-Astro / AMReX-Astro/Castro
should we drop to Godunov if interface prediction wants rho < small_dens?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
Right now, if the interface prediction for density is > small_dens, we set the interface state to density. But this will yield a thermodynamically inconsistent state.
A better approach might be to simply drop to 1st order Godunov in these rare cases?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the Castro source for small_dens, interface prediction, and first-order Godunov handling; no file or test is named in the issue. Read the surrounding hydrodynamics logic and identify the relevant validation tests, then determine whether the thermodynamically inconsistent state should trigger a Godunov fallback and what test demonstrates the chosen behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100