AMReX-Astro / AMReX-Astro/Castro
revisit the transverse update
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
Right now, we do the transverse correction to the conserved state + p. This way we don't need to use the EOS to get p on the interface when we go back to the primitive state for the Riemann solve.
But the EOS is pretty cheap now (with the templating), that it might be cleaner and more robust to update the conserved system, derive (rho e) after the correction and handle it in the same dual energy fashion as we do elsewhere, and then use ctoprim to get the new corrected primitive edge state.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the transverse correction to the conserved state and p, then compare it with the dual-energy handling used elsewhere and the ctoprim path for the corrected primitive edge state. Done means the correction uses the revised conserved-state and dual-energy approach while producing the corrected primitive edge state for the Riemann solve.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100