AMReX-Astro / AMReX-Astro/Castro
can we switch the fluxes MF to a fluxregister?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
Right now, we create a MF fluxes where we add the fluxes during a subcycle, eventually copying them into the flux register. The hydro routines do not operate on the flux register directly, but instead increment the fluxes. We need this intermediate array to allow for the retry functionality. But this requires a lot of memory. Can we get away with replacing the fluxes MF with a second flux register?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Trace the hydro routines that increment the intermediate fluxes MF, the flux-register copy, and the retry path; determine whether a second flux register preserves subcycle accumulation and retries without the intermediate array. Done means the replacement is validated for the affected hydrodynamics workflows and avoids the current memory cost.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100