AMReX-Astro / AMReX-Astro/Castro
consider computing geometry on demand via inlined functions
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
Right now we carry around 3 area MFs + 1 volume MF. These are not used very widely, and it seems that with the C++ conversion, we could create an inlined function area() and volume() to compute these as needed and apply them immediately. This will free up 4 Real's per zone of memory in MFs.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the three area MFs and one volume MF per zone in the C++ code, then inspect how widely they are used. The work is done when equivalent area and volume values are computed on demand, existing behavior is preserved, and the four Real values per zone are no longer stored.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100