AMReX-Astro / AMReX-Astro/Castro
HLLC solver has incomplete godunov interface state
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
We only fill the normal velocity and pressure of the Godunov state when doing HLLC, and even this is in an approximate way that is inconsistent with HLLC. We should have a different code path when using HLLC that avoids the need for the interface states.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by tracing the HLLC implementation and its Godunov interface-state handling, then compare that path with the solver's other interface-state paths. Done means HLLC no longer depends on incomplete approximate interface states and its behavior is covered by relevant validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100