AMReX-Astro / AMReX-Astro/Castro
revisit CMA
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
Currently we do the "consistent multifluid advection" method by constraining the species fluxes to sum to the density flux after we have done all of the transverse flux differences.
But CMA was developed for a directionally-split method. It might be the case that we want to normalize the fluxes after each Riemann solve, before they are applied to the conservative states in the transverse direction, as well as for the final construction.
Alternately, we might want to just switch to normalizes the species interface states themselves.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by locating the consistent multifluid advection (CMA) implementation and the Riemann-solve and transverse-flux update paths. Compare normalizing after each Riemann solve with normalizing species interface states, then define and validate the chosen behavior; the issue does not specify a completion test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100