AMReX-Astro / AMReX-Astro/Castro
get rid of grav_source_type < 4
Open
Nobody has claimed this yet.
clean-up
gravity
hackathon
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
The older gravity source types are really not as good. Certainly types 1 and 3 aren't ever used. grav_source_type = 2 might be useful for comparison purposes, but also could probably go.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating all references to grav_source_type and determine where types 1, 2, and 3 are defined, selected, or documented. Check the relevant tests or example configurations before changing anything; done means the obsolete types are removed consistently and the affected tests or configurations still work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100