AMReX-Astro / AMReX-Astro/Castro
gwstrain FPE when running with true SDC
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
For true SDC (USE_TRUE_SDC = TRUE), when we finish a step and enter the sum_utils, we get an FPE in the gwstrain calculation. This is likely because the true SDC algorithm never fills the new Gravity_Type state data.
To reproduce this bug, compile bubble_convergence in debug mode, make sure that castro.sum_interval=1 is set, and run with amrex.fpe_trap_invalid=1.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by compiling bubble_convergence in debug mode and reproduce the FPE with castro.sum_interval=1 and amrex.fpe_trap_invalid=1. Trace the true SDC path into sum_utils and the gwstrain calculation, checking how Gravity_Type state data is populated. Done means the reproduced run no longer raises an invalid-operation FPE.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100