AMReX-Astro / AMReX-Astro/Castro
Make gravity StateData nodal
@maximumcats is already working on this.
Since Dec 3, 2020.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
The gravitational acceleration (g, not phi) is most naturally expressed at cell edges rather than cell centers in the Poisson gravity formulation, and it is straightforward to express it at edges for other forms like monopole and constant gravity. If we did this then the conservative gravity source term would be more straightforward to write the way we want (right now we are recovering cell edges by averaging between cell centers adjacent to the edge, which is not as good as just having the exact cell edge value directly from the Poisson solver).
We may want to wait until after #580 is merged to make this change.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.