AMReX-Astro / AMReX-Astro/Castro
Switch to key = value format for _prob_params
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 340
- Forks
- 105
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Description
The _prob_params script (and perhaps later on _cpp_parameters and the extern variables) should be switched to a key = value format so that we can more easily add fields in the future. For example we could do Python's ConfigParser format so that
p_ambient real 1.e-5_rt y
becomes (perhaps)
[p_ambient]
type = real
default = 1.e-5_rt
namelist = True
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the _prob_params script and trace how its current records are parsed and consumed. Review the proposed ConfigParser-style format and determine whether _cpp_parameters and extern variables are in scope. Done means the parameter format and affected entry points are defined, with tests or representative inputs covering the new fields.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100